[v14.x] worker: fix --abort-on-uncaught-exception handling#34815
Closed
addaleax wants to merge 1 commit intonodejs:v14.x-stagingfrom
Closed
[v14.x] worker: fix --abort-on-uncaught-exception handling#34815addaleax wants to merge 1 commit intonodejs:v14.x-stagingfrom
addaleax wants to merge 1 commit intonodejs:v14.x-stagingfrom
Conversation
The `set_abort_on_uncaught_exception(false)` line was supposed to prevent aborting when running Workers in `--abort-on-uncaught-exception` mode, but it was incorrectly set and not checked properly in the should-abort callback. PR-URL: nodejs#34724 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
Collaborator
BethGriggs
approved these changes
Aug 18, 2020
BethGriggs
pushed a commit
that referenced
this pull request
Aug 18, 2020
The `set_abort_on_uncaught_exception(false)` line was supposed to prevent aborting when running Workers in `--abort-on-uncaught-exception` mode, but it was incorrectly set and not checked properly in the should-abort callback. PR-URL: #34724 Backport-PR-URL: #34815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
Member
|
Landed in c3371f6 |
BethGriggs
pushed a commit
that referenced
this pull request
Aug 20, 2020
The `set_abort_on_uncaught_exception(false)` line was supposed to prevent aborting when running Workers in `--abort-on-uncaught-exception` mode, but it was incorrectly set and not checked properly in the should-abort callback. PR-URL: #34724 Backport-PR-URL: #34815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
addaleax
added a commit
that referenced
this pull request
Sep 23, 2020
The `set_abort_on_uncaught_exception(false)` line was supposed to prevent aborting when running Workers in `--abort-on-uncaught-exception` mode, but it was incorrectly set and not checked properly in the should-abort callback. PR-URL: #34724 Backport-PR-URL: #34815 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
set_abort_on_uncaught_exception(false)line was supposed toprevent aborting when running Workers in
--abort-on-uncaught-exceptionmode, but it was incorrectly setand not checked properly in the should-abort callback.
PR-URL: #34724
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Richard Lau riclau@uk.ibm.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Mary Marchini oss@mmarchini.me